-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure Cognitive Search to latest stable/GA Python SDK version + Renaming to Azure AI Search #924
Conversation
@pablocastro please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments to the notebook that would be good to address.
examples/vector_databases/azuresearch/Getting_started_with_azure_ai_search_and_openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/azuresearch/Getting_started_with_azure_ai_search_and_openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/azuresearch/Getting_started_with_azure_ai_search_and_openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/azuresearch/Getting_started_with_azure_ai_search_and_openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/azuresearch/Getting_started_with_azure_ai_search_and_openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/azuresearch/Getting_started_with_azure_ai_search_and_openai.ipynb
Outdated
Show resolved
Hide resolved
LGTM |
@simonpfish @shyamal-anadkat requesting review :) |
@teomusatoiu @ibigio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! Especially appreciate the blurbs explaining what the code blocks do – super helpful. Quality contribution.
thanks @ibigio can we get this merged please? |
…+ Renaming to Azure AI Search (#924)
Summary
This PR updates the Vector Database example in the Azure Search Cookbook to utilize the latest stable General Availability (GA) release of the Azure AI Search Python SDK. Additionally, it includes renaming instances of "Azure Search" to "Azure AI Search" to reflect the current branding and product naming conventions.
Motivation
The Azure Search Cookbook is a valuable resource for developers working with Azure AI Search. Keeping the cookbook examples up-to-date with the latest SDK ensures that users have access to the most current features and best practices. The rebranding from "Azure Search" to "Azure AI Search" aligns the cookbook with the official terminology, reducing confusion and improving searchability.
For new content
When contributing new content, read through our contribution guidelines, and mark the following action items as completed:
We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.