stream param to Speech and AsyncSpeech #724
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help.openai says, in https://help.openai.com/en/articles/8555505-tts-api#h_f2f424c6cb
However, the API reference does not have such a param in https://platform.openai.com/docs/api-reference/audio/createSpeech
The guide again says, in https://platform.openai.com/docs/guides/text-to-speech:
However, the code there seems like it reads the content in full, before responding over http?
I tried to experiment, and indeed it seemed that that version did not stream.
I modified the speech part of the client lib to pass the
stream: bool
onwards, and I think this way it actually works, my playback starts so soon. I did not verify this (yet) with proper debugging.This should be considered a draft, because apparently the
stream=True
param for thespeech.create
changes the return type fromHttpxBinaryResponseContent
toAsyncStream
. I did not fix the type infos etc.