Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): ensure setter method updates both _base_url and client.base_url #914

Closed
wants to merge 2 commits into from
Closed

fix(client): ensure setter method updates both _base_url and client.base_url #914

wants to merge 2 commits into from

Conversation

tomoish
Copy link
Contributor

@tomoish tomoish commented Dec 1, 2023

base_url of an OpenAI client instance cannot be changed by setter method.

This PR updates the setter method to change both _base_url and client.base_url.

Closes #913.

@tomoish tomoish requested a review from a team as a code owner December 1, 2023 13:35
@RobertCraigie
Copy link
Collaborator

Thanks @tomoish! We actually want this fix to be slightly different and not set the base_url property on the underlying http client as well.

I've pushed a fix separately for this and marked you as a co-author, #919.

@tomoish tomoish deleted the fix-base-url branch December 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base_url of OpenAI Client Instance Cannot Be Modified Due to Missing Update in Setter Method
2 participants
@tomoish @RobertCraigie