Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triton does not support Python 3.12 yet #2707

Closed
TheEgghead27 opened this issue Nov 28, 2023 · 4 comments
Closed

Triton does not support Python 3.12 yet #2707

TheEgghead27 opened this issue Nov 28, 2023 · 4 comments

Comments

@TheEgghead27
Copy link

Because triton does not support Python 3.12 yet, users of any projects that depend on it (such as https://github.com/openai/whisper) are met with pip dependency resolution errors, and are unable to work with these projects without having to manually install an older edition of Python.

It would be appreciated if Python 3.12 support were added, though it is not necessary for many use cases, and it is totally understandable if this is to be tabled for a later date, given that Python 3.12 comes with a plethora of breaking changes.

@jlebar
Copy link
Collaborator

jlebar commented Nov 28, 2023

Ugh, thank you for the bug report. I don't want to make life difficult for downstream consumers.

I'm not an expert in Python packaging, so I may be missing something. But I installed Python 3.12 and set up a virtualenv.
I was unable to install torch.

$ pip install torch
Looking in indexes: http://nginx.pypi.svc.cluster.local/simple/
ERROR: Could not find a version that satisfies the requirement torch (from versions: none)
ERROR: No matching distribution found for torch

torch is a prerequisite for running most of the Triton tests, so if I can't install it, I can't really test that Triton works with Python 3.12.

Looks like this is blocked on pytorch/pytorch#110436.

@jlebar
Copy link
Collaborator

jlebar commented Nov 28, 2023

users of any projects that depend on it (such as https://github.com/openai/whisper) are met with pip dependency resolution errors

Also, I may not be reading this correctly, but I don't think Whisper requires Python 3.12? https://github.com/openai/whisper/blob/e58f28804528831904c3b6f2c0e473f346223433/setup.py#L26

Your problem may be that you're running with Python 3.12, not that Whisper is requiring it. The Torch bug has instructions for running with an older Python.

@jlebar jlebar closed this as completed Nov 28, 2023
@TheEgghead27
Copy link
Author

Hi Justin, thank you for looking into this!

Definitely makes sense that 3.12 support for Triton (and in turn Whisper) will have to come after PyTorch; maybe one day we'll be able to bring the entire toolchain up to speed!

For now, I'll keep Python 3.11 in my workflows.

@EwoutH
Copy link

EwoutH commented Apr 3, 2024

Some updates on Python 3.12 support in PyTorch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants