Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPLIT] Added optional device specific notes #221

Merged

Conversation

anon1892
Copy link
Member

@anon1892 anon1892 commented Aug 1, 2023

Added optional device specific notes support. They are shown on top of the ROM choosing page.

Work started in #188

Tested and working fine.

EDIT : Added optional brand and untested metadata, as demanded in #114

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

@MagicLike What do you think about it?

@MagicLike
Copy link
Member

@MagicLike What do you think about it?

Looks nice! ❤️

@tsterbak tsterbak added the enhancement New feature or request label Aug 4, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.5.0 milestone Aug 4, 2023
@tsterbak tsterbak changed the base branch from main to dev-0.5.0 August 4, 2023 07:51
@tsterbak tsterbak changed the base branch from dev-0.5.0 to dev-flash-additional August 16, 2023 08:22
@tsterbak tsterbak merged commit 757a85c into openandroidinstaller-dev:dev-flash-additional Aug 16, 2023
tsterbak added a commit that referenced this pull request Aug 16, 2023
Work started and tested in #188 : working

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`)
- #220 for additional partitions support
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
Work started and tested in #188 : works fine

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
Work started in #188 

Untested but should work (same steps as #222 )

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
Work started and tested in #188 : working

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
Work started in #188 

Untested but should work

Requirements : 
- #218 for OrangeFox support (optional)
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
#228)

Related to issue #85. Not tested !

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)

Actually, the best way of testing may be using the `main` branch of [my
fork](https://github.com/anon1892/oai/tree/main), since it need 3 PR to
work as is.
tsterbak added a commit that referenced this pull request Sep 27, 2023
Related to issue #232.  Not tested !

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)

@Chronos093
tsterbak added a commit that referenced this pull request Sep 27, 2023
Untested ! Asked in #212. @alkman1982 do you want to help us by testing
it?

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`)
- #220 for additional partitions support
- #221 for device specific notes (optional)

I used this :
https://forum.xda-developers.com/t/rom-t-unofficial-lineageos-20-0-for-redmi-k20-pro-mi-9t-pro-raphael.4464937/
@anon1892 anon1892 deleted the notes branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants