Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for miatoll (Xiaomi Redmi Note 9 Pro / 9S ... Poco M2 Pro) #228

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

anon1892
Copy link
Member

@anon1892 anon1892 commented Aug 2, 2023

Related to issue #85. Not tested !

Requirements :

Actually, the best way of testing may be using the main branch of my fork, since it need 3 PR to work as is.

@MagicLike
Copy link
Member

Tagging @RaptaG

@RaptaG
Copy link
Contributor

RaptaG commented Aug 2, 2023

How do it test it?

@RaptaG
Copy link
Contributor

RaptaG commented Aug 2, 2023

Tagging @RaptaG

🙏🏽

@MagicLike
Copy link
Member

How do it test it?

Two ways: You temporaily build OAI locally (this will include using the terminal) or I / @anon1892 can try to build you a version.

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

@RaptaG As written in the first post of this pull request, the simplest way is to clone the main branch of my repo
Then follow the README to start app. (make poetry, make install and make app)

@MagicLike
Copy link
Member

@RaptaG As written in the first post of this pull request, the simplest way is to clone the main branch of my repo Then follow the README to start app. (make poetry, make install and make app)

Oh I overread that - do you just merge all your commits to the branches into your main?

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

Not the last ones (changes in notes, brand and untested), but should work the same way.

I just tested building, it just builds Linux executable, not windows one. Don't know how to do 😅

@MagicLike
Copy link
Member

I just tested building, it just builds Linux executable, not windows one. Don't know how to do sweat_smile

Are you on Linux?

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

Yes

@MagicLike
Copy link
Member

MagicLike commented Aug 2, 2023

Yes

Ohhh ok, I think Windows needs to be build on Windows... But don't worry, just head to the "Actions" tab of your repo and enable actions. Then run manual-build. (you can select the branch) It should spit out Linux, Mac and Windows files

@MagicLike
Copy link
Member

@RaptaG On what OS is your PC?

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

Thank you for the explanation.
For Windows, it's here : https://we.tl/t-MXhgQW2Muo
For Fedora : https://we.tl/t-CTxKo1Z1km

EDIT : Links were broken

@RaptaG
Copy link
Contributor

RaptaG commented Aug 2, 2023

@RaptaG On what OS is your PC?

I run Fedora Linux, yes I could compile the app locally

@MagicLike
Copy link
Member

@RaptaG On what OS is your PC?

I run Fedora Linux, yes I could compile the app locally

no need, it is already compiled and should work -> https://github.com/anon1892/oai/suites/14768652533/artifacts/839864734

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

I updated the links 😉

@MagicLike
Copy link
Member

I updated the links wink

but why were they broken - they worked for me

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

Ah ? I tried in private tab (to know if they was session only), and was redirected to 404

@MagicLike
Copy link
Member

Ah ? I tried in private tab (to know if they was session only), and was redirected to 404

GitHub Actions artifacts can only be downloaded with an account

@RaptaG
Copy link
Contributor

RaptaG commented Aug 2, 2023

GitHub Actions artifacts can only be downloaded with an account

you could also use https://nightly.link

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

Ok. Good to know, thanks both.

@tsterbak tsterbak added the device Request to add or improve a specific device. label Aug 4, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.5.0 milestone Aug 4, 2023
@MagicLike MagicLike linked an issue Sep 8, 2023 that may be closed by this pull request
@anon1892 anon1892 mentioned this pull request Sep 26, 2023
3 tasks
@tsterbak tsterbak changed the base branch from main to dev September 27, 2023 14:55
@tsterbak tsterbak merged commit 5f79942 into openandroidinstaller-dev:dev Sep 27, 2023
@RaptaG
Copy link
Contributor

RaptaG commented Sep 27, 2023

🎉

@anon1892 anon1892 deleted the miatoll branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device Request to add or improve a specific device.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Xiaomi Redmi Note 9 Pro
4 participants