Merge pull request #523 from wjt/faster-highlight-creation

Faster highlight creation
openannotation · May 3, 2015 · e355de6 · e355de6
2 parents cb8d6c4 + 2b2700e
commit e355de6
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/ui/highlighter.js b/src/ui/highlighter.js
@@ -21,8 +21,6 @@ function highlightRange(normedRange, cssClass) {
     }
     var white = /^\s*$/;
 
-    var hl = $("<span class='" + cssClass + "'></span>");
-
     // Ignore text nodes that contain only whitespace characters. This prevents
     // spans being injected between elements that can only contain a restricted
     // subset of nodes such as table rows and lists. This does mean that there
@@ -33,9 +31,11 @@ function highlightRange(normedRange, cssClass) {
     for (var i = 0, len = nodes.length; i < len; i++) {
         var node = nodes[i];
         if (!white.test(node.nodeValue)) {
-            results.push(
-                $(node).wrapAll(hl).parent().show()[0]
-            );
+            var hl = document.createElement('span');
+            hl.className = cssClass;
+            node.parentNode.replaceChild(hl, node);
+            hl.appendChild(node);
+            results.push(hl);
         }
     }
     return results;