Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java, adds enums and uses them in Schema validate methods #344

Merged
merged 56 commits into from
Dec 28, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Dec 25, 2023

Java, adds enums and uses them in Schema validate methods
Updates

  • Schema.getSchemas refactored into generator method
  • Java schema docs improved, only list array/map builder and output classes in summary if those exist in getschemas. Also conditionally lists enums of they exist
  • Java, removes unused imports from schemas

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title Java, adds enums and uses them as inputs to the validate method Java, adds enums and uses them in Schema validate methods Dec 25, 2023
…lue, produces 4 types of number in enumInfo typeToValues
@spacether spacether merged commit f557d28 into master Dec 28, 2023
5 checks passed
@spacether spacether deleted the feat_java_adds_enums branch December 28, 2023 02:41
@spacether spacether mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant