-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply encodeURIComponent on path parameter value #1696
Conversation
🦋 Changeset detectedLatest commit: 2f853c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Good addition, but could you add a test (preferably one that fails before this change)? Thanks! |
I am sorry. I am unable to provide a test. I have difficulties to work on the project. I installed
I tried it both, running |
The package’s CONTRIBUTING guide has some basic instructions on test setup. You can also inspect Also make sure you have pnpm 9 (current) and Node 22 (current) installed. |
I finally managed to run tests and found that the |
Ah yes you’re right! Good catch—I agree that’s an improvement. This PR still needs a test unique to your change, though! Preferably one that fails before your change. |
I added two more tests and changed the existing "allows UTF-8 characters" test slightly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
I am glad that I could help. When will this be released? I will have to remove a workaround in our code base and would prefer to do it soon. |
It’s being published right now 🙂. Thanks to changesets, the release process is automated |
* Apply encodeURIComponent on path parameter value * add changeset * Fix "params / path / allows UTF-8 characters" test * Add more tests for path parameter encoding --------- Co-authored-by: Stefan Wachter <stefan.wachter@otto.de>
Changes
Fixes #1596
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)