Adding CGM support for Dexcom touchscreen receivers #1182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest node-js for raspbian deprecates the use of nodejs-legacy, which breaks this script on new pi installs. This will make it so that nodejs-legacy is only installed on the edison.
* Adds ``g6`` and ``g6-upload`` support for Dexcom touchscreen CGM receivers. Note that these work with G5 transmitters as well.
scottleibrand
approved these changes
Jan 16, 2019
|
Am I reading this correctly that it's safe to merge this even without openaps/openaps#139, but that is a dependency for actually selecting g6 or g6-upload when running oref0-setup? |
|
This one is safe to merge before #139 and the underlying dexcom_reader project. But that's correct that the user should not specify G6 or G6-upload. |
cluckj
reviewed
Feb 25, 2019
| @@ -682,6 +684,9 @@ if [[ $REPLY =~ ^[Yy]$ ]]; then | |||
| if [[ ${CGM,,} =~ "g5" || ${CGM,,} =~ "g5-upload" ]]; then | |||
| openaps use cgm config --G5 | |||
| openaps report add raw-cgm/raw-entries.json JSON cgm oref0_glucose --hours "24.0" --threshold "100" --no-raw | |||
| elif [[ ${CGM,,} =~ "g6" || ${CGM,,} =~ "g6-upload" ]]; then | |||
| openaps use cgm config --G6 | |||
| openaps report add raw-cgm/raw-entries.json JSON cgm oref0_glucose --hours "24.0" --threshold "100" --no-raw | |||
There was a problem hiding this comment.
Thanks for fixing this bug! I ran into it a while ago and gave up on it because I couldn't track it down in the time I had. I'm closing this PR and opening a new one that both adds setup support for touchscreen receivers, fixes this bug, and makes some changes to oref0-cron-every-minute to make the CGM loop work with the new receivers too.
|
Replacing with #1217 |
scottleibrand
pushed a commit
that referenced
this pull request
Mar 11, 2019
… receivers (#1217) * Add support for touchscreen receivers, fix CGM loop bug for connected receivers Changed files: `oref0-setup.sh` - Includes cgm_loop_path fix found by @chuckj for both G5 and G6 (8799a13 to fix #1149) and includes support for G5/G6 touch receivers (previously under #1182) `oref0-cron-every-minute.sh` - Reincluding support for offline CGM, with optional upload, for G5 and G6 receivers * Readding accidentally removed logging Reenables apache-chainsaw support * Resolving conflicts with newly merged changes * Touchup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g6andg6-uploadsupport for Dexcom touchscreen CGM receivers. Note that these receivers work with G5 transmitters as well.Must merge these two in order first for this to work without breaking things: