Only install local hostspot if selected #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/determine-basal/determine-basal.js
Conflicts: lib/determine-basal/determine-basal.js
|
Fine keeping 72e6a6e in as long as they both get merged in soon-ish to dev. This LGTM. |
|
We probably need (someone) to re-run oref0-setup with and without this option to confirm everything works as expected. |
|
If no objections, it'd probably be easiest to merge this to dev for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading rigs, we often see them go offline after updating their hostapd or dnsmasq packages, necessitating a hard reboot before we can log back in and re-run oref0-setup. This PR only installs such local-only hotspot packages if the user wishes to use them, which should improve reliability for everyone else.
This PR also fixes the xdrip-js setup to run
cgm-transmitterautomatically. If desired, we could commit or PR that to dev separately: the commit is 72e6a6e