Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for bolus to complete and refresh pumphistory after SMB/enact #667

Merged
merged 17 commits into from
Sep 24, 2017

Conversation

scottleibrand
Copy link
Contributor

This makes oref0 refresh pumphistory after an SMB/enact so that it can be displayed more promptly in NS.

@jaylagorio
Copy link
Contributor

only refresh after SMB/enact; wait_for_silence 10 if blousing - would this not refresh after a temp? That's OK if so, just trying to clarify. Otherwise this one looks good to me!

@scottleibrand
Copy link
Contributor Author

Yes, that is intentional. It also refreshes any time a >30m low temp is still running, even if not new, which is IMO an acceptable side effect for simplicity's sake. If we wanted to instead to modulus math we could, but my first attempt didn't work so I decided not to.

Conflicts:
	bin/oref0-pump-loop.sh
@scottleibrand scottleibrand merged commit 4e3d0a0 into dev Sep 24, 2017
@scottleibrand scottleibrand deleted the refresh-if-temp-recent branch September 24, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants