Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better filtering for large data sources #547

Closed
jflasher opened this issue Nov 4, 2018 · 4 comments
Closed

Add better filtering for large data sources #547

jflasher opened this issue Nov 4, 2018 · 4 comments

Comments

@jflasher
Copy link
Contributor

jflasher commented Nov 4, 2018

If we can add better filtering for ChinaAQIData and Arpalazio, I think it'd go a ways towards avoiding timeouts. My guess is that some of the timeouts (when fetch doesn't finish in time) are happening because we're trying to save a lot of measurements to the database (even if they're duplicates).

@MichalCz
Copy link
Contributor

Joe, just thinking out loud, but on arpalazio I think it may be a small change in line 131 - from filter to until... I'll check that out. Ideally not the whole file would get loaded...

@MichalCz
Copy link
Contributor

Well... that doesn't work well with request - sadly it crashes because of ending the piped stream before the data is consumed...

I must think of that scenario on newer versions. So this is not really an option. :(

@jflasher
Copy link
Contributor Author

jflasher commented Nov 21, 2018 via email

@majesticio
Copy link
Contributor

I'm closing this issue because these adapters aren't currently being used and the fetch process has been updated since this issue was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants