Israel source support for Envista adapter (#358) #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP Richards Bay adapter Done: - Get cities list - Get stations list - Query station - Get CSV Todo: - Parse CSV - Format data * Script to get Richards Bay station coordinates * Fix country field in source file * Working adapter Each station has their own cookie jar to avoid server export issue (see #9) TODO * Customize lstMonitors to reduce response size * Try to cut out unuseful stations early * Lint fix * It wasn't timing out after all * Keep the todo on the issue * Customize lstMonitors, only get what you need * Lint... * Skip boring stations * Attemp to customize envista adapter for Israel * Works perfect 90% of the time * Use retry and parallelLimit * Support both IL, ZA in Envista adapter * Use different request objects for each source * Custom form handling for each source * Use region name as city * Skip non number measurement values * Get attribution name from source * Other conditionals based on source country * Change adapter name * Gotta keep Travis happy, lint * Add Israel station coordinates Max wrote the helper script in adapters/israel branch, I made a few modifications: * The returned locations are now a single hashmap, instead of a list of objects * Use stationID to map coordinates, to avoid the unicode key problem. I used the same stationID trick from the Moscow adapter. See the following comment about the problem: #301 (comment) * Lint with updated eslint (Mine was older than what was on Travis) * Skip 0,0 coordinates * Remove outdated envista_za.js adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.