Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard_v2: add node as a local dependency #93

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

tspmelo
Copy link

@tspmelo tspmelo commented Feb 13, 2018

This will allow us to use the angular cli on systems that don't have node
v6.9.0 or higher installed.

Signed-off-by: Tiago Melo tmelo@suse.com

@sebastian-philipp sebastian-philipp added this to the Initial PR milestone Feb 13, 2018
rjfd
rjfd previously approved these changes Feb 14, 2018
Copy link

@rjfd rjfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

callithea
callithea previously approved these changes Feb 14, 2018
Devp00l
Devp00l previously approved these changes Feb 14, 2018
votdev
votdev previously approved these changes Feb 14, 2018
LenzGr
LenzGr previously approved these changes Feb 14, 2018
This will allow us to use the angular cli on systems that don't have node
v6.9.0 or higher installed.

Signed-off-by: Tiago Melo <tmelo@suse.com>
Copy link

@rjfd rjfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tspmelo tspmelo merged commit 60e1300 into openattic:wip-mgr-dashboard_v2 Feb 14, 2018
@tspmelo tspmelo deleted the node-req branch February 14, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants