Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URL links in the payment response #351

Closed
3 tasks done
jsanhc opened this issue Mar 12, 2021 · 0 comments
Closed
3 tasks done

Wrong URL links in the payment response #351

jsanhc opened this issue Mar 12, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jsanhc
Copy link
Contributor

jsanhc commented Mar 12, 2021

Description

The payment read/write APIs version 3.1 to 3.1.2 response with wrong version of links.self because the controller implementation it's an extension of minor version and then the link.self version it's the version of the extended controller.
Example:

// version 3.1
"Links": {
        "Self": "https://api.alphabank.com/open-banking/v3.1/pisp/domestic-payment-consents/58923/funds-confirmation"
    },
    "Meta": {}
// version 3.1.2
"Links": {
        "Self": "https://api.alphabank.com/open-banking/v3.1/pisp/domestic-payment-consents/58923/funds-confirmation"
    },
    "Meta": {}

It's expected "Self": "....../.../v3.1.2/....." instead of "Self": "....../.../v3.1/....."

  • Versions affected from 3.1 to 3.1.2.

Tasks

  • Check other APIs if they have the same issue.
  • Fix link.self through all APIs.
  • Test fix.
@jsanhc jsanhc self-assigned this Mar 12, 2021
@jsanhc jsanhc added the bug Something isn't working label Mar 15, 2021
@jsanhc jsanhc added this to To do in OpenBankingToolkit via automation Mar 15, 2021
@jsanhc jsanhc moved this from To do to Work In Progress (Finish these!!!) in OpenBankingToolkit Mar 15, 2021
@jsanhc jsanhc moved this from Work In Progress (Finish these!!!) to Done in OpenBankingToolkit Mar 18, 2021
@jsanhc jsanhc closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant