Skip to content

Commit

Permalink
Remove app-id from tests
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
  • Loading branch information
cipherboy committed Jan 26, 2024
1 parent 5c39814 commit ec4698a
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions helper/builtinplugins/registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,14 @@ func Test_RegistryGet(t *testing.T) {
want: toFunc(credUserpass.Factory),
wantOk: true,
},
{
// The app-id plugin has been fully removed from OpenBao.
/*{
name: "removed builtin lookup",
builtin: "app-id",
pluginType: consts.PluginTypeCredential,
want: nil,
wantOk: true,
},
},*/
{
name: "known builtin lookup",
builtin: "mysql-database-plugin",
Expand Down Expand Up @@ -208,13 +209,14 @@ func Test_RegistryStatus(t *testing.T) {
want: consts.Deprecated,
wantOk: true,
},*/
{
// The app-id plugin has been fully removed from OpenBao.
/*{
name: "removed builtin lookup",
builtin: "app-id",
pluginType: consts.PluginTypeCredential,
want: consts.Removed,
wantOk: true,
},
},*/
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down

0 comments on commit ec4698a

Please sign in to comment.