Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gofumpt required gating test #29

Closed
cipherboy opened this issue Dec 21, 2023 · 2 comments
Closed

Make gofumpt required gating test #29

cipherboy opened this issue Dec 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cipherboy
Copy link
Member

As noted in #28 and current project config, upstream's preference was not to strictly require formatting to succeed, but make it an optional job. IMO it is better to enforce this, since it is project-wide and Go has good community integration for formatters.

See e.g. https://github.com/openbao/openbao/blob/development/Makefile#L248-L249 for make invocation

This will help ensure consistency in PRs and avoid unnecessary follow-ups fixing formatting.

@cipherboy
Copy link
Member Author

@Scorpil Scorpil added the enhancement New feature or request label Jan 2, 2024
cipherboy pushed a commit to cipherboy/openbao that referenced this issue Jan 21, 2024
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
@naphelps
Copy link
Member

Format is now a required workflow gating PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants