gofmt entire project #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
|
@naphelps this should be good to merge. :-) I'll file an issue about making gofmt be a required gating test. |
naphelps
approved these changes
Dec 22, 2023
cipherboy
pushed a commit
to cipherboy/openbao
that referenced
this pull request
Jan 21, 2024
cipherboy
pushed a commit
to cipherboy/openbao
that referenced
this pull request
Jan 21, 2024
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some exploratory work to deal with the circular imports between this repo and https://github.com/openbao/openbao-plugin-secrets-kv, and I noticed that my diffs were being muddied by
gofmttweaks affecting source files throughout the project.This commit runs
gofmtover every.gofile in the repo to do this as a big bang and keep spurious changes out of subsequent diffs.