Part 13/n - Remove non-OSI auth methods from API #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier we removed several auth plugins (AWS, Azure, and GCP in openbao#101). Because we no longer support them in-tree, we'll want to remove their API helpers as well; instead, each out-of-tree plugin should have an api/ folder which contains similar code as this. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
remove-non-osi-api-auth-methods
branch
from
64c67de
to
e0df834
Compare
naphelps
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we removed several auth plugins (AWS, Azure, and GCP in #101). Because we no longer support them in-tree, we'll want to remove their API helpers as well; instead, each out-of-tree plugin should have an api/ folder which contains similar code as this.
Part of #68; broken up for reviewability.