-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vault->OpenBao in the UI #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
update-vault-ui-references
branch
2 times, most recently
from
February 12, 2024 02:51
4fc8094
to
d73ba38
Compare
Resolves: openbao#74 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
update-vault-ui-references
branch
from
February 22, 2024 17:02
d73ba38
to
9251618
Compare
These are a mix of Vault Enterprise only components and removed auth or secrets engines. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
This gets farther now, but I'm not seeing the error: test output
|
naphelps
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the UI to replace references to Vault with references to OpenBao instead. References to Vault Enterprise were retained, as were the docs.
I mostly went through this with grep; I'd suggest using a build (
make static-dist dev-ui
-- see build dependencies underui/README.md
) to walk through it to find any missing references, IMO.Related: #74
Note: this PR will not resolve the branding assets issue as mentioned in #74, so that will have to remain open.