Fix running API, SDK tests & vetting #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMa
approved these changes
Feb 23, 2024
naphelps
force-pushed
the
fix-tests-run-everything
branch
from
e49918a
to
59dd1b8
Compare
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: openbao#61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
fix-tests-run-everything
branch
from
59dd1b8
to
b9e23af
Compare
naphelps
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #61, the tests for the
api/andsdk/subpackages were not run; this fixes the failing tests and adds them to the Makefile so this should be prevented in the future.Resolves: #61