Fork & Bug: API & SDK are not tested #61
Milestone
Comments
|
I guess using Also, this prevents getting test output live as I've discovered some time ago in hashicorp/terraform-provider-helm#186 (review) (maybe not true any longer nowadays). |
Just so I'm clear, what is the alternative you're proposing? Note that this repo has both sub-modules ( From my trial, these don't work: openbao]$ go test github.com/openbao/openbao
ok github.com/openbao/openbao 0.021s [no tests to run]
openbao]$ go test
testing: warning: no tests to run
PASS
ok github.com/openbao/openbao 0.021s
openbao]$ go test .
ok github.com/openbao/openbao (cached) [no tests to run]
openbao]$ go test openbao
package openbao is not in std (/usr/local/go/src/openbao)And I get a rather cryptic errors trying to do things like: openbao]$ go test ./sdk/
no Go files in /home/cipherboy/GitHub/openbao/openbao/sdk
openbao]$ go test ./sdk/helper/
no Go files in /home/cipherboy/GitHub/openbao/openbao/sdk/helper
openbao]$ go test ./sdk/helper/certutil/
main module (github.com/openbao/openbao) does not contain package github.com/openbao/openbao/sdk/helper/certutil
openbao]$ go test sdk/helper/certutil/
package sdk/helper/certutil is not in std (/usr/local/go/src/sdk/helper/certutil)
openbao]$ go test ./sdk/helper/certutil
main module (github.com/openbao/openbao) does not contain package github.com/openbao/openbao/sdk/helper/certutil
openbao]$ go test github.com/openbao/openbao/sdk
no required module provides package github.com/openbao/openbao/sdk; to add it:
go get github.com/openbao/openbao/sdkthough interestingly, cd'ing is sufficient: Even though I'm able to do openbao]$ go test ./api/
main module (github.com/openbao/openbao) does not contain package github.com/openbao/openbao/api
openbao]$ go test api
package api is not in std (/usr/local/go/src/api)
openbao]$ go test github.com/openbao/openbao/api
ok github.com/openbao/openbao/api 13.452sSo I think the best thing to do is something like: ...perhaps? |
|
Hmm, I can't even build the Do you have additional changes locally to make it work? |
|
Hi @pdecat sorry, this was discussed on the LF Element/Matrix bridge but not brought here -- In the mean time, aligning with #64, PR #56 has a branch that should build but fail tests, and my |
I was essentially proposing to run But right now, I see this is triggering lots of errors even for the root module: |
|
@pdecat Hmm, I would've expected those failures if you were before 34c0163 on Edit: ec4698a is now the latest commit. All the tests should pass except these: in These require |
|
Oh ok, I misread your previous comment and checked out the wrong branch with Things are way better on |
naphelps
pushed a commit
that referenced
this issue
Feb 2, 2024
cipherboy
changed the title
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Feb 22, 2024
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: openbao#61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
to cipherboy/openbao
that referenced
this issue
Feb 27, 2024
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: openbao#61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
to cipherboy/openbao
that referenced
this issue
Feb 27, 2024
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: openbao#61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
that referenced
this issue
Feb 27, 2024
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: #61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Gabrielopesantos
pushed a commit
to Gabrielopesantos/openbao
that referenced
this issue
Mar 1, 2024
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: openbao#61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Mar 2, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Mar 3, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Mar 3, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#42 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Gabrielopesantos
pushed a commit
to Gabrielopesantos/openbao
that referenced
this issue
Mar 4, 2024
This adds testing of API & SDK packages to the Makefile, letting `make test` run them by default. This should fix issues where either is broken as they weren't being run by most test executions. Resolves: openbao#61 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
to cipherboy/openbao
that referenced
this issue
Mar 5, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#42 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
that referenced
this issue
Mar 5, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing #61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: #31 Resolves: #42 Resolves: #152 Related: #153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OpenBao has a few Go modules in the same repository:
However, when running
go list ./...from the root, a few aren't found:Output
In particular,
sdkandapiaren't listed. This issue appears to persist on the originalrelease/1.14.xbranch. The result is that both have test failures.This usage of
go list ./...and omission of these modules needs to be addressed in theMakefile, building, and CI systems at least, in addition to fixing the test failures.The text was updated successfully, but these errors were encountered: