Remove Performance Secondary, DR Secondary consts #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
perf-secondary-cleanup
branch
from
ba39bff
to
c936d71
Compare
This code was added to Vault Enterprise to allow Standby nodes of Performance Secondary clusters to write up to their Active node. Because this code isn't present in OSS, these stubs should be removed and the changes reverted. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
From the core vault/ and http/ space, remove references to Performance Secondary and Disaster Recovery Secondary clusters as they are Vault Enterprise only functionality. This lets us simplify some of the semantics around forwarding of requests (removing many no-ops in the process) and execution of tasks (again, mostly removing no-ops and unnecessary channels). Also regenerates all protobuf files, causing a few extraneous checkins with the new version. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Non-voting nodes and certain autopilot features are limited to Vault Enterprise only. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Census reporting is a Vault Enterprise feature related to automatic billing adjustments based on client counting. This is unnecessary in OpenBao, though client counting remains. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
perf-secondary-cleanup
branch
from
c936d71
to
771ca00
Compare
naphelps
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes references to Enterprise-only functionality from Vault core:
These are all only useful in a Vault Enterprise context, and we do not have the implementation code behind them; thus, remove many of these helpers and constants allowing us to simplify control flow in many instances, focusing only on the HA mode present in OpenBao.