Remove activity log from OpenBao #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
remove-activity-counting
branch
from
06a56ef
to
7714a71
Compare
cipherboy
force-pushed
the
remove-activity-counting
branch
from
7714a71
to
e25c518
Compare
The activity log subsystem was an upstream specific mechanism to handle counting of "clients" (for some definition there-of, mostly focused around combining the concept of an entity with some equivalence relation for non-entity tokens to reduce the total number), for the express purpose of billing customers. This code was thus in OSS so that, on purchasing an Enterprise license, an idea of pricing could be established. As we don't have Vault Enterprise, removing this code is likely best as it allows us to avoid having to maintain it going forward and avoids any incompatibilities with upstream if they were to change the definitions. See also: https://developer.hashicorp.com/vault/docs/concepts/client-count/counting See also: https://developer.hashicorp.com/vault/api-docs/system/internal-counters Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
remove-activity-counting
branch
from
e25c518
to
aa3ca33
Compare
naphelps
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activity log subsystem was an upstream specific mechanism to handle
counting of "clients" (for some definition there-of, mostly focused
around combining the concept of an entity with some equivalence relation
for non-entity tokens to reduce the total number), for the express
purpose of billing customers. This code was thus in OSS so that, on
purchasing an Enterprise license, an idea of pricing could be
established.
As we don't have Vault Enterprise, removing this code is likely best as
it allows us to avoid having to maintain it going forward and avoids any
incompatibilities with upstream if they were to change the definitions.
See also: https://developer.hashicorp.com/vault/docs/concepts/client-count/counting
See also: https://developer.hashicorp.com/vault/api-docs/system/internal-counters
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>This will be rebased once #193 is merged.