Transit: Remove enterprise no-ops references from API and SDK #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabrielopesantos
force-pushed
the
gabrielopesantos/remove-transit-enterprise-no-ops
branch
from
0552789
to
d4d1052
Compare
cipherboy
reviewed
Mar 10, 2024
cipherboy
reviewed
Mar 10, 2024
Gabrielopesantos
force-pushed
the
gabrielopesantos/remove-transit-enterprise-no-ops
branch
from
d4d1052
to
fa535cf
Compare
Gabrielopesantos
force-pushed
the
gabrielopesantos/remove-transit-enterprise-no-ops
branch
from
307e469
to
985f5b7
Compare
cipherboy
approved these changes
Mar 12, 2024
naphelps
approved these changes
Mar 13, 2024
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Gabrielopesantos
force-pushed
the
gabrielopesantos/remove-transit-enterprise-no-ops
branch
from
985f5b7
to
c2f7bd6
Compare
naphelps
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #142, it removes the managed_key_util.go file from the Transit engine, with no-ops enterprise functions and all of these functions.
Besides that, it also removes all references and usages of managed keys in the engine and SDK.