Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to enterprise in vault/ #197

Merged

Conversation

cipherboy
Copy link
Member

This removes enterprise stubs related to quotas, licenses, undo logs (a
Vault Enterprise feature related to performance secondaries and Raft),
WALs, authorization policies that only exist in Enterprise, handling
control groups, managed keys, and other nil functions.


Based on #195; will be rebased once that merges.

This removes enterprise stubs related to quotas, licenses, undo logs (a
Vault Enterprise feature related to performance secondaries and Raft),
WALs, authorization policies that only exist in Enterprise, handling
control groups, managed keys, and other nil functions.

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
@cipherboy cipherboy force-pushed the remove-core-references-to-enterprise branch from f3d9d6f to d15c0f2 Compare March 12, 2024 19:04
@cipherboy cipherboy marked this pull request as ready for review March 12, 2024 19:04
Copy link
Contributor

@Gabrielopesantos Gabrielopesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this PR, and others have opened, remove all remaining enterprise stubs and references?

@cipherboy
Copy link
Member Author

@Gabrielopesantos said:

Looks good. Does this PR, and others have opened, remove all remaining enterprise stubs and references?

Just in Vault Core, API, and SDK, when not related to plugin support for Perf or DR replication.

I think some plugins might have some stubs (you handle the Transit ones in #196 that I don't deal with at all), plus many of them have stuff around write semantics with Perf Secondary clusters.

@naphelps naphelps self-requested a review March 13, 2024 14:03
@naphelps naphelps merged commit 6855744 into openbao:main Mar 13, 2024
41 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants