Remove Server Side Consistent Tokens (SSCTs) #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
remove-ssct-generation
branch
2 times, most recently
from
772aa57
to
3699cd7
Compare
cipherboy
force-pushed
the
remove-ssct-generation
branch
from
3699cd7
to
a416ec2
Compare
SSCTs were a Vault Enterprise feature, implemented everywhere, to introduce tokens which encoded information about Performance Secondary replication state into requests. This let callers pass this token to any other server and guarantee their state is at least as fresh as this token (by virtue of it containing a WAL index number). However, this didn't apply to HA clusters and only to Performance Secondary cluster types, meaning it is of limited utility to us. We revert to the old token prefixes (`s.`, `b.`, and `r.`), rather than continuing to use the SSC Token prefixes (`hvs.`, `hvb.`, and `hvr.`). This ensures any utilities attempting to decode Vault's SSCTs knows these do not have the required internal structure. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
remove-ssct-generation
branch
from
a416ec2
to
1f2635c
Compare
naphelps
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSCTs were a Vault Enterprise feature, implemented everywhere, to
introduce tokens which encoded information about Performance Secondary
replication state into requests. This let callers pass this token to any
other server and guarantee their state is at least as fresh as this
token (by virtue of it containing a WAL index number). However, this
didn't apply to HA clusters and only to Performance Secondary cluster
types, meaning it is of limited utility to us.
We revert to the old token prefixes (
s.,b., andr.), rather thancontinuing to use the SSC Token prefixes (
hvs.,hvb., andhvr.).This ensures any utilities attempting to decode Vault's SSCTs knows
these do not have the required internal structure.
Based on #197; will be rebased once that merges.