Server: Update references to server environment variables to reflect new name #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
reviewed
Mar 20, 2024
There was a problem hiding this comment.
So far we did not touch it. Therefore I also left the docs mostly unchanged for now. IMO if there's no-one willing to support it before GA, we should remove the docs.
cipherboy
approved these changes
Mar 20, 2024
Gabrielopesantos
force-pushed
the
gabrielopesantos/rename-server-vars-refs
branch
from
d34b882
to
e2ce224
Compare
Gabrielopesantos
force-pushed
the
gabrielopesantos/rename-server-vars-refs
branch
from
e2ce224
to
816b0f8
Compare
cipherboy
approved these changes
Mar 25, 2024
|
@Gabrielopesantos There is a single commit that requires a --signoff for the DCO check to pass. https://github.com/openbao/openbao/pull/207/checks?check_run_id=23078806963 |
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Gabrielopesantos
force-pushed
the
gabrielopesantos/rename-server-vars-refs
branch
from
816b0f8
to
fda9cbb
Compare
@naphelps Addressed 👍 . |
naphelps
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the references to server environment variables, from prefix with "VAULT" to "BAO", in the documentation.
These variables were initially updated in the PR linked below.
Follow up to #157
Target Release
Alpha