Use api.ReadBaoVariable everywhere #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
use-read-bao-variable-everywhere
branch
from
f73aafa
to
a7e5e2a
Compare
This was referenced Feb 24, 2024
This also enables usage with non-Bao prefixed variables and prevents weird reads if one is accidentally used. Further, by using os.LookupEnv(...), we can return an empty BAO_ prefixed variable value if it is explicitly set, over returning a populated VAULT_ variable instead. Similarly, we introduce LookupBaoVariable to handle places where we need to check if the variable was set as well. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
This addresses more cases where os.LookupEnv was used instead of os.GetEnv, so we prefer the Bao-aware api.LookupBaoVariable in these cases instead. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
use-read-bao-variable-everywhere
branch
from
a7e5e2a
to
d87417b
Compare
naphelps
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #138; will be rebased when that one merges.
This cleans up the logic of
api.ReadBaoVariablea touch, and then replaces a bunch of instances ofos.GetEnvwithapi.ReadBaoVariableinstead.I'm thinking perhaps we want to have an option (
BAO_IGNORE_VAULT_VARIABLES) might be useful to globally ignoreVAULT_prefixed environment variables? That way Vault and Bao could coexist on the same system with different environments and not have a partial environment from one leak into the other?Thoughts?