Fix API & SDK failing tests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With d34da50, behavior was made to align with Go's handling of Unix sockets that changed due to a security vulnerability. However, the tests were not updated to reflect using localhost here, resulting in the api package failing. See also: https://nvd.nist.gov/vuln/detail/CVE-2023-29406 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
fix-api-sdk-tests
branch
from
93071f8
to
564bb89
Compare
naphelps
approved these changes
Jan 25, 2024
naphelps
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be run manually with:
Note that, for some reason I haven't yet figured out, the former can be run from the root with
go test github.com/openbao/openbao/api. but the SDK doesn't run similarly.Related: #61