119 implement low battery notification system #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…://github.com/openbase/bco into 119-implement-low-battery-notification-system
DivineThreepwood
added
the
prebuild docker image
lhuxohl
requested changes
Dec 27, 2023
module/api/graphql/src/main/java/org/openbase/bco/api/graphql/schema/RegistrySchemaModule.kt
Show resolved
Hide resolved
module/app/preset/src/test/java/org/openbase/bco/app/preset/DeviceNotificationAppTest.kt
Outdated
Show resolved
Hide resolved
module/app/preset/src/main/java/org/openbase/bco/app/preset/DeviceNotificationApp.kt
Outdated
Show resolved
Hide resolved
module/app/preset/src/test/java/org/openbase/bco/app/preset/DeviceNotificationAppTest.kt
Outdated
Show resolved
Hide resolved
…eeps, cleanup unique label consistency handling. Fix rpc exception serialization to improve debugging experience. Reimplement location type dectection. Code cleanup and java -> kotlin transformations.
|
Thanks for the feedback, all changes and some additional debugging has been addressed. |
DivineThreepwood
removed
the
prebuild docker image
lhuxohl
requested changes
Jan 9, 2024
module/registry/lib/src/main/java/org/openbase/bco/registry/lib/util/LocationUtils.kt
Outdated
Show resolved
Hide resolved
...-registry/core/src/main/java/org/openbase/bco/registry/unit/core/UnitRegistryController.java
Outdated
Show resolved
Hide resolved
.../bco/registry/unit/core/consistency/connectionconfig/ConnectionLocationConsistencyHandler.kt
Show resolved
Hide resolved
...ry/lib/src/main/java/org/openbase/bco/registry/unit/lib/auth/AuthorizationWithTokenHelper.kt
Outdated
Show resolved
Hide resolved
lhuxohl
previously approved these changes
Jan 9, 2024
DivineThreepwood
added
code approved
prebuild docker image
lhuxohl
previously approved these changes
Feb 20, 2024
lhuxohl
approved these changes
Feb 20, 2024
DivineThreepwood
added
tested
and removed
prebuild docker image
DivineThreepwood
deleted the
119-implement-low-battery-notification-system
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request: