Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove org.openbmc.* from REST server #2378

Closed
geissonator opened this issue Sep 27, 2017 · 5 comments
Closed

Remove org.openbmc.* from REST server #2378

geissonator opened this issue Sep 27, 2017 · 5 comments
Assignees
@ngorugan
Labels
bug prio_medium
Milestone
IBM Milestone 2

Comments

@geissonator
Copy link
Contributor

geissonator commented Sep 27, 2017 •
edited by rfrandse
Loading

cde:info SW407587 </cde:info>
The goal here is to put a filter on what the REST server allows users to read and write. Basically anything using the old org.openbmc would not be allowed in our out via REST.
@rfrandse rfrandse added this to the openBMC v2.0 Backlog milestone Sep 27, 2017
@dkodihal dkodihal mentioned this issue Oct 3, 2017
Closed
@dkodihal
Copy link
Contributor

@ngorugan @bradbishop I'm thinking this can be a plug-in which runs on each request, checks if the request url consists of /org/openbmc, if so, fails with a 'not allowed'.

@rfrandse
Copy link

https://gerrit.openbmc-project.xyz/7422 Remove org.openbmc.* from REST server
Resolves #2378 Remove org.openbmc.* from REST server

@zahrens zahrens added the zflag label Oct 26, 2017
@dkodihal dkodihal mentioned this issue Nov 9, 2017
Closed
@zahrens zahrens added v2.00 and removed Phase 6 labels Nov 10, 2017
@zahrens zahrens modified the milestones: openBMC v2.0 Backlog, OpenBMC v2.1 Backlog Nov 10, 2017
@mine260309
Copy link
Contributor

This breaks the code update for non-UBIFS BMCs, a.k.s all OpenBMC machines except Witherspoon.
I suggest revert it ASAP and commit it back until we have moved all services under /org/openbmc/ to /xyz/openbmc_project/

@geissonator geissonator reopened this Jan 26, 2018
@geissonator
Copy link
Contributor Author

We'll need to put this new code in it's own file, so it can easily be pulled in for just systems that want it.

@rfrandse
Copy link

https://gerrit.openbmc-project.xyz/10209 Remove org.openbmc.* from REST server
Resolves #2378 Remove org.openbmc.* from REST server

@gkeishin gkeishin mentioned this issue Jul 24, 2018
Closed
geissonator pushed a commit to openbmc/openbmc-test-automation that referenced this issue Jul 24, 2018
@gkeishin
Base /org/ and /xyz/ are blocked
611398c 
As per new changes openbmc/openbmc#2378 the /org/ and /xyz/ are no
longer accessible. The URLs listed below are white-listed.

{
"urls": [
    "/org/open_power/*",
    "/com/ibm/*",
    "/xyz/openbmc_project/*",
    "/enumerate",
    "/list",
    "/login",
    "/logout",
    "/subscribe",
    "/upload/image",
    "/download/dump/*"
    ]
}

Resolves  #1423

Change-Id: I6d033dc4b53af06adb655c40cea6cd58270be8fa
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngorugan ngorugan

Labels
bug prio_medium
Projects
None yet
Milestone
IBM Milestone 2
Development

No branches or pull requests
6 participants
@mine260309 @geissonator @rfrandse @zahrens @dkodihal @ngorugan