Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still a few unresolved ecb issues #206

Closed
mhcwebdesign opened this issue Nov 19, 2023 · 2 comments
Closed

Still a few unresolved ecb issues #206

mhcwebdesign opened this issue Nov 19, 2023 · 2 comments

Comments

@mhcwebdesign
Copy link
Contributor

I think you have to replace all calls to

$this->model_setting_extension->getInstalled('currency');
with

$this->model_setting_extension->getExtensionsByType('currency');

Also, the admin/language/en-gb/setting/setting.php has some missing entries:

$_['entry_currency_engine']          = 'Currency Rate Engine';
....
$_['help_currency_auto']             = 'Set your store to automatically update currencies daily. It requires a chosen Currency Rate Engine.';

And in the System > Localisation > Currencies it comes up with the wrong info message:

This extension requires the EUR currency.

Only when you try to refresh the currencies should it check for existence of the EUR when the ECV is the chosen currency engine.

Nothing major, not hard to fix it all.

@TheCartpenter
Copy link
Collaborator

It was never about how hard people thinks it is, it is rather how quick the issue can be reported to fix it.

@mhcwebdesign
Copy link
Contributor Author

mhcwebdesign commented Nov 20, 2023

Just added another pull request #207 with some final bugfixes. I grabbed them from the 3.0.x.x, and they should also work for this opencart-3 repository. Tested it all for opencart-3 to be certain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants