New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still a few unresolved ecb issues #206
Comments
TheCartpenter
added a commit
that referenced
this issue
Nov 19, 2023
TheCartpenter
added a commit
that referenced
this issue
Nov 19, 2023
It was never about how hard people thinks it is, it is rather how quick the issue can be reported to fix it. |
Just added another pull request #207 with some final bugfixes. I grabbed them from the 3.0.x.x, and they should also work for this opencart-3 repository. Tested it all for opencart-3 to be certain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think you have to replace all calls to
$this->model_setting_extension->getInstalled('currency');
with
$this->model_setting_extension->getExtensionsByType('currency');
Also, the admin/language/en-gb/setting/setting.php has some missing entries:
And in the System > Localisation > Currencies it comes up with the wrong info message:
This extension requires the EUR currency.
Only when you try to refresh the currencies should it check for existence of the EUR when the ECV is the chosen currency engine.
Nothing major, not hard to fix it all.
The text was updated successfully, but these errors were encountered: