[Master] ECB bug currency rate?

[condor2]

What version of OpenCart are you reporting this for?
Master branch

Describe the bug

I have refreshed ECB currency and EURO vs USD is:

0.84602094 | 1.00000000

On 3.0.x.x is

0.91979397 | 1.00000000

Both oc version has this URL in ecb

https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml

[ADDCreative]

The calculations are different. Try.

$this->model_localisation_currency->editValueByCode($result['code'], $currencies[$result['code']] / $value);

[condor2]

With that line changed work.

[mhcwebdesign]

Well, the value shown on OC 3.0.x.x is the correct one, the one from the OC 4 master branch appears to be wrong.

[TheCartpenter]

So is the correct one from the opencart-3 originally.

[danielkerr]

MOST LIKELY SOME NE POSTED A COMMIT TO MESS THINGS UP

[danielkerr]

So is the correct one from the opencart-3 originally.

VERSION 3 DOES NOT HAVE ECB

[TheCartpenter]

So is the correct one from the opencart-3 originally.

VERSION 3 DOES NOT HAVE ECB

It's sad to see that you seem to be a bit late in the news on this one since OC v3.0.x.x and opencart-3, both, have the ECB integrated already as you are the one who officially put the version number for it afterwards.

[danielkerr]

versoin 3 stilll uses yahoo

[condor2]

https://github.com/opencart/opencart/blob/3.0.x.x/upload/admin/controller/extension/currency/ecb.php

[TheCartpenter]

versoin 3 stilll uses yahoo

That's right, @danielkerr. Version 3 still uses Yahoo:

https://github.com/opencart/opencart/blob/3.0.x.x/upload/admin/controller/extension/currency/ecb.php

admin/controller/extension/currency/ecb.php
admin/model/extension/currency/ecb.php
admin/view/template/extension/currency/ecb.twig
catalog/controller/extension/currency/ecb.php
catalog/model/extension/currency/ecb.php
install/opencart.sql

[mhcwebdesign]

3.0.3.9 uses Yahoo, the latter has been defunct for quite a while now.
3.0.x.x uses the ecb, which I backported from OpenCart 4.
And it was also then copied over by @TheCartpenter to opencart-3.

Hope this clarifies it.

[TheCartpenter]

The above is not entirely true in regard to 'copied'. It is not a verbatim copy while I did took portion of the MB as well to achieve this on the opencart-3 repository.

[mhcwebdesign]

The above is not entirely true in regard to 'copied'. It is not a verbatim copy while I did took portion of the MB as well to achieve this on the opencart-3 repository.

OK, thanks for the clarification. BTW.: I can't see the Extensions > Extensions > Currency Rates in the admin backend of opencart-3, there should be one pointing to available currency engines.

[danielkerr]

if anyone wants to maybe move some of the fixes accross

[danielkerr]

i need to do another update foor opayo

[TheCartpenter]

The above is not entirely true in regard to 'copied'. It is not a verbatim copy while I did took portion of the MB as well to achieve this on the opencart-3 repository.

OK, thanks for the clarification. BTW.: I can't see the Extensions > Extensions > Currency Rates in the admin backend of opencart-3, there should be one pointing to available currency engines.

Done.

[mhcwebdesign]

Done.

See also this issue: opencart/opencart-3#206