Skip to content

Commit

Permalink
Fix double encoding of ampersand in some urls for google_sitemap.php.…
Browse files Browse the repository at this point in the history 
… $this->url->link handles it.

Close #3057
  • Loading branch information
@jamesallsup
jamesallsup committed May 27, 2015
1 parent bb8cb45 commit 06fe3e5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions upload/catalog/controller/feed/google_sitemap.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function index() {

foreach ($products as $product) {
$output .= '<url>';
$output .= '<loc>' . $this->url->link('product/product', 'manufacturer_id=' . $manufacturer['manufacturer_id'] . '&amp;product_id=' . $product['product_id']) . '</loc>';
$output .= '<loc>' . $this->url->link('product/product', 'manufacturer_id=' . $manufacturer['manufacturer_id'] . '&product_id=' . $product['product_id']) . '</loc>';
$output .= '<changefreq>weekly</changefreq>';
$output .= '<priority>1.0</priority>';
$output .= '</url>';
Expand Down Expand Up @@ -92,7 +92,7 @@ protected function getCategories($parent_id, $current_path = '') {

foreach ($products as $product) {
$output .= '<url>';
$output .= '<loc>' . $this->url->link('product/product', 'path=' . $new_path . '&amp;product_id=' . $product['product_id']) . '</loc>';
$output .= '<loc>' . $this->url->link('product/product', 'path=' . $new_path . '&product_id=' . $product['product_id']) . '</loc>';
$output .= '<changefreq>weekly</changefreq>';
$output .= '<priority>1.0</priority>';
$output .= '</url>';
Expand Down

2 comments on commit 06fe3e5

@Ergotron-User
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! for the code...

@mrg123
Copy link

@mrg123 mrg123 commented on 06fe3e5 Jun 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found it ,you are right

Please sign in to comment.