OC4: fix broken utf8_substr with default 0 length

Now it always returns an empty string
opencart · May 30, 2022 · 3a2c5aa · 3a2c5aa
1 parent 022cdfe
commit 3a2c5aa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/upload/system/helper/utf8.php b/upload/system/helper/utf8.php
@@ -16,7 +16,7 @@ function utf8_strrpos(string $string, string $needle, int $offset = 0) {
 	}
 
 	function utf8_substr(string $string, int $offset, int $length = 0) {
-		if ($length === '') {
+		if ($length == 0) {
 			return mb_substr($string, $offset, utf8_strlen($string));
 		} else {
 			return mb_substr($string, $offset, $length);
@@ -45,7 +45,7 @@ function utf8_strrpos(string $string, string $needle) {
 	}
 
 	function utf8_substr(string $string, int $offset, int $length = 0) {
-		if ($length === '') {
+		if ($length == 0) {
 			return iconv_substr($string, $offset, utf8_strlen($string), 'UTF-8');
 		} else {
 			return iconv_substr($string, $offset, $length, 'UTF-8');