-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summernote fails to initiliaze when using multiple locale #10259
Comments
We need to add language code at admin in ISO 639-1 formate. http://i.prntscr.com/ZSa4WpfoR4C2oqDg9b41Jg.png |
Well, it's quite stupid doing it this way with language.locale:
While the language file has already the correct definiton(s) summernote:
And no need to use ISO 639-1 format (which is btw. only a 2-letter code!). And the language definition code should be the same as the directory. |
It should be de-DE (because all OpenCart packages have the summernote languages like xx-YY.js). |
Wrong. The default for German language files in Opencart is |
|
As you suggested, we will do it in a better way, we will update you shortly. |
Beside this "discussion", summernote use xx-YY as language codes, see: And what I've added to the German language pack is a reworked summernote de-DE translation because the one provided with the original packages are quite old .. |
@webkul-dilip 21 days later - and no update or fix?? |
sorry for the delay, now we have fixed the issue |
Merged PR #10275 |
@Opencart-Webkul when will this patch be available in an update for OC? |
@opencart If all updates would be so fast as deleting comments, more users would be satisfied. |
What version of OpenCart are you reporting this for?
3.0.3.8
Describe the bug
Summernote
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Summernote should not fail initialzing when multiple local identifiers are defined
Screenshots / Screen recordings
Server / Test environment (please complete the following information):
Additional context
only specifying a single locale willl result in working summernote. For example:
de
however when I be more specific it fails again. For example:de-de
The text was updated successfully, but these errors were encountered: