-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect response code header in "catalog\controller\error\not_found.php" #1620
Comments
jamesallsup
added a commit
that referenced
this issue
Jul 10, 2014
jamesallsup
added a commit
that referenced
this issue
Jul 10, 2014
@benej60 well spotted :) That's been patched now in the 156x and 2.0 branch. |
ADDCreative
added a commit
to opencart-ce/opencart-ce
that referenced
this issue
Jul 10, 2014
ADDCreative
added a commit
to opencart-ce/opencart-ce
that referenced
this issue
Jul 10, 2014
Wow! Nice turnaround time. |
zilgrg
pushed a commit
to zilgrg/opencart
that referenced
this issue
Oct 1, 2014
zilgrg
pushed a commit
to zilgrg/opencart
that referenced
this issue
Oct 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This line:
$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . '/1.1 404 Not Found');
...results in:
HTTP/1.1/1.1 404 Not Found
It should be changed to:
$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
It actually seems to work fine, at least in Chrome, but it is still incorrect.
I'm using 1.5.5.1, but based on the description from issue #1032, looks like it has not yet been patched.
The text was updated successfully, but these errors were encountered: