Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event action names are inconsistent #2214

Closed
ghost opened this issue Nov 5, 2014 · 1 comment
Closed

Event action names are inconsistent #2214

ghost opened this issue Nov 5, 2014 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 5, 2014

Some events are named in the form of action.subject (e.g. pre.admin.delete.category, post.admin.edit.marketing) while others are subject.action (e.g. pre.customer.add, post.order.edit).

Also, is everything not specifically marked as admin meant to be catalog?

@ghost
Copy link
Author

ghost commented Nov 7, 2014

Thanks! I see you stripped the "admin" prefix out. How are potential event naming collisions between admin and catalog going to be handled (for example, creating a customer account or an order)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant