Bug in admin/model/setting/setting.php

[mhcwebdesign]

This is for OC 2.0.2.0 and the current master branch:

In file admin/model/setting/setting.php, in method editSettingValue, the following line

$this->db->query("UPDATE " . DB_PREFIX . "setting SET `value` = '" . $this->db->escape($value) . "' WHERE `code` = '" . $this->db->escape($code) . "' AND `key` = '" . $this->db->escape($key) . "' AND store_id = '" . (int)$store_id . "'");

should be replaced with this:

$this->db->query("UPDATE " . DB_PREFIX . "setting SET `value` = '" . $this->db->escape($value) . "', serialized = '0'  WHERE `code` = '" . $this->db->escape($code) . "' AND `key` = '" . $this->db->escape($key) . "' AND store_id = '" . (int)$store_id . "'");

Otherwise, if the previous setting value was a serialised value, and is about about to be updated with a non-serialised string value, it keeps the wrong 'serialised=1'.

[Ergotron-User]

Thanks