Problem with cart edit method.

[sbthemes]

Hi,
I was working on project and for that I need custom cart page. SO to update cart item I used cart.update method which is located in common.js file

This function is passing data like this:
Line no 178 in common.js
data: 'key=' + key + '&quantity=' + (typeof(quantity) != 'undefined' ? quantity : 1),

Means it is passing integer or string quantity value.

Now look at controller.

In controller checkout/cart.php file you can find public function edit() { at line no 391
Function is something like this:

public function edit() {
    $this->load->language('checkout/cart');
    $json = array();
    // Update
    if (!empty($this->request->post['quantity'])) {
        foreach ($this->request->post['quantity'] as $key => $value) {
            $this->cart->update($key, $value);
        }

This function assume quantity value as array and running foreach loop. But in common.js update method, it is passing string or integer.

So error generates Invalid argument to supplied to foreach.

So I think in this function need to check if value is array or not.

I am little bit familiar with opencart structure but this is just my second opencart project.

So if I am doing wrong here. Please point me. I am not sure common.js is common or it is based on theme.
Let me know if any questions.

Thanks.

[sbthemes]

Hey,
I can't see any change on master copy. So am I wrong?

[milimar]

The right place to post your issue is here: http://forum.opencart.com

Greetings!

[sbthemes]

Okay thanks.
Actually I have posted here because I don't need solution. I thought it is bug in open cart. I don't know where to post bug.
By the way thanks.

[milimar]

Yes, this is the right place for posting bugs, but your issues is closed because Daniel considers it is not a bug...that's all :)

[sbthemes]

I am not sure you have checked my explanation or not. This is surely bug. You can try update method and pass quantity as integer and you will get error.

I am using latest version of opencart.