Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer check for Curl HTTP Loopback support #3062

Closed
qphoria opened this issue May 29, 2015 · 10 comments
Closed

Installer check for Curl HTTP Loopback support #3062

qphoria opened this issue May 29, 2015 · 10 comments

Comments

@qphoria
Copy link
Contributor

qphoria commented May 29, 2015

I do a lot of upgrades to 2.x and I think about 35% of people's servers DO NOT support curl http loopback which means the API calls throw an ajax error and people cannot do any of the API calls like edit orders or update order history. This is a pretty major showstopper and I think a check should be done during install to see that curl loopback is enabled.

The easiest way would be to simply attempt a curl call to the main install index and either check the response isn't empty, or use curl_getinfo() to check the http_code. This returns "0" on sites that do not have loopback enabled.

It should also be documented somewhere explaining the issue. Backupbuddy for Wordpress has some info for their own system here: http://ithemes.com/codex/page/BackupBuddy:_Frequent_Support_Issues#HTTP_Loopback_Connections_Disabled

@sculptex
Copy link

I second that. My hosting did not really understand the issue when I tried to explain and wanted to start poking around in the software. So there definitely needs to be an official page to explain the issue that people can direct their hosting to.
That said, considering over 1/3rd have this problem, isn't it a bit unrealistic to expect so many to get their hosting to change to accommodate this? If less than 5% maybe but 35%? So perhaps there should be a workaround which would only be enabled if the issue was identified on install.

@exit15
Copy link

exit15 commented May 30, 2015

I posted a comment at #3062. Don't know if this makes sense, but would it not be better if supporting curl http loopback was not a "requirement"? My server supports loopback, but when trying to use CDN service like Cloud Flare I got the same error because of the way they handle DNS routing.

@qphoria
Copy link
Contributor Author

qphoria commented May 31, 2015

The design really isn't bad, it's just unfortunate that servers are not willing to enable it.
The only workaround I have would be to create a subdomain and have a redirect script on that subdomain to bounce around the servers, thus bypassing loopback. I am making a script for that for a client of mine. We shall see if it works

@danielkerr
Copy link
Member

can changing the URL to localhost or 127.0.0.1?

@danielkerr
Copy link
Member

Ok i have a solution. Need to set a config value so a sub domain can be used. Maybe api.yourstore.com

@danielkerr
Copy link
Member

that did not work either. looks like i'm rewriting the order editor system

@juankadiaz
Copy link

Hi! I have the same bug!! any news on this?

Thank you very much for contributions.

@sculptex
Copy link

How is this closed? Daniel have you approved this? So many changes here, far more than just curl issue fix.
Addition of define.php, admin/define.php, system/library/client.php, system/library/modification.php, system/library/trigger.php, system/library/utility.php,
Is this where opencart is going otherwise this will surely break with next release?

@qphoria
Copy link
Contributor Author

qphoria commented Jun 25, 2015

Daniel has rewritten it to use another method in the next version. Meanwhile I have a work around here: http://forum.opencart.com/viewtopic.php?f=34&t=146714#p567180

@danielkerr
Copy link
Member

i closed the issue because some d*** head is trying to market their project via github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants