Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0.0.0] "code" column in "setting" table is too short #5408

Closed
ClearThinking opened this issue May 3, 2017 · 1 comment
Closed

[3.0.0.0] "code" column in "setting" table is too short #5408

ClearThinking opened this issue May 3, 2017 · 1 comment

Comments

@ClearThinking
Copy link

Because 3.0 now requires the code be prefixed with the extension type, it's very easy to go over 32 characters for an extension code. I'd recommend increasing it to at least 64, or perhaps just use 255 for both the "code" and "key" columns in the database, to allow for longer-named settings.
danielkerr added a commit that referenced this issue May 5, 2017
@danielkerr
https://github.com/opencart/opencart/issues/5408
695baf4
@ClearThinking
Copy link
Author

Thanks! You should also change the "key" column for the "setting" table, since all keys need to be prefixed with the code, so it will always be longer than the "code" column.

OpenCartAddons added a commit to OpenCartAddons/opencart that referenced this issue May 5, 2017
@OpenCartAddons
Update opencart.sql
644ee6b 
Increased "key" character limit as per opencart#5408
@OpenCartAddons OpenCartAddons mentioned this issue May 5, 2017
Merged
arnisjuraga added a commit to copona/copona that referenced this issue May 10, 2017
@arnisjuraga
Increase setting table code and key length opencart/opencart#5408
c5e80ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ClearThinking @danielkerr