New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.x support for 3.0.x.x maintenance branch (09-03-2022) #10467
Merged
mhcwebdesign
merged 40 commits into
opencart:3.0.x.x_Maintenance
from
mhcwebdesign:3.0.x.x_Maintenance
Apr 30, 2022
Merged
PHP 8.x support for 3.0.x.x maintenance branch (09-03-2022) #10467
mhcwebdesign
merged 40 commits into
opencart:3.0.x.x_Maintenance
from
mhcwebdesign:3.0.x.x_Maintenance
Apr 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to add PHP8.x-support for the 3.0.x.x_Maintenance branch.
It includes minor changes to the following PHP files:
upload/admin/model/dashboard/extension/sale.php
upload/catalog/controller/startup/startup.php
upload/catalog/model/catalog/product.php
upload/system/library/db/mysqli.php
upload/system/library/session/db.php
composer.json
composer.lock
And it also includes an update to the current versions of the upload/system/storage/vendor folders and files (too many to be listed here), which I did via composer. The most important one of these is the usage of the latest Twig 3.3.8. And the addition of some formerly corrupted or missing vendor sub-folders for e.g. 'klarna/rco_rest' or 'cardinity/cardinity-sdk-php' etc.