Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OC4: fix broken utf8_substr with default 0 length #10944

Merged
merged 1 commit into from May 30, 2022
Merged

OC4: fix broken utf8_substr with default 0 length #10944

merged 1 commit into from May 30, 2022

Conversation

stalker780
Copy link
Contributor

Now it always returns an empty string

@stalker780
OC4: fix broken utf8_substr with default 0 length
3a2c5aa 
Now it always returns an empty string
@stalker780
Copy link
Contributor Author

However it is not quite correct too.
If there is a need to use 0 length, it will never work. It will always return full string.
Behavior will be different from original php substr function.

@danielkerr danielkerr merged commit 7425e8b into opencart:master May 30, 2022
@ADDCreative
Copy link
Contributor

#11073 should be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stalker780 @ADDCreative @danielkerr