Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backquotes - admin/model/catalog/category.php file #11285

Merged
merged 1 commit into from Jun 14, 2022

Conversation

TheCartpenter
Copy link
Contributor

No description provided.

@mhcwebdesign
Copy link
Collaborator

mhcwebdesign commented Jun 14, 2022

What is it these days with the backquote obsession? It's neither needed, nor is it a bug.

@TheCartpenter
Copy link
Contributor Author

It ain't about these days. It's about server specs where even partial characters of reserved terms would prevent SQL queries to load. It's been like this a long time with PHP. The rest just goes to the people to catch up on it.

@mhcwebdesign
Copy link
Collaborator

Well, category_id isn't one of the reserved words: https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-8-0-detailed-I

@TheCartpenter
Copy link
Contributor Author

What that site doesn't reveal is how PHP has its unique case compared to the rest of the programming industry since it's the only language where backquotes needs to be used aside from the others even on the reserved terms whether it's partial or full.

@mhcwebdesign
Copy link
Collaborator

No, not inside PHP strings, e.g. "I can have any keyword inside my string, such as category namespace class etc".

@danielkerr danielkerr merged commit 07e185a into opencart:master Jun 14, 2022
@danielkerr
Copy link
Member

it is weird!

@TheCartpenter TheCartpenter deleted the patch-928 branch December 9, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants