Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed SQL abbreviation typo and pushed space - upload/system/library/db.php file #11619

Merged
merged 1 commit into from Aug 31, 2022
Merged

Fixed SQL abbreviation typo and pushed space - upload/system/library/db.php file #11619

merged 1 commit into from Aug 31, 2022

Conversation

TheCartpenter
Copy link
Contributor

No description provided.

cgcmart
cgcmart reviewed Aug 30, 2022
View reviewed changes
Copy link

@cgcmart cgcmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 41, line 52, line 54

@TheCartpenter
Copy link
Contributor Author

@cgcmart: What's wrong with these lines?

@cgcmart
Copy link

cgcmart commented Aug 30, 2022

file source comparison: you corrected line 41, but left line 52 and line 54.
db

@TheCartpenter
Copy link
Contributor Author

Based on other system/library files, those spaces are identical as well after the variable types. Depth's on 2 spaces.

@danielkerr danielkerr merged commit cf873f5 into opencart:master Aug 31, 2022
@TheCartpenter TheCartpenter deleted the patch-1046 branch December 9, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgcmart cgcmart cgcmart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheCartpenter @cgcmart @danielkerr