Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need leading space to prevent appending to link #12223

Merged
merged 1 commit into from Jul 5, 2023

Conversation

daretogo
Copy link

Without a leading space before "the" the word "The" ends up getting appended to the reset link resulting in users clicking on it and getting an "invalid reset link" message.

Without a leading space before "the" the word "The" ends up getting appended to the reset link resulting in users clicking on it and getting an "invalid reset link" message.
@danielkerr danielkerr merged commit fc4a086 into opencart:3.0.x.x_Maintenance Jul 5, 2023
@ADDCreative
Copy link
Contributor

I don't believe this isn't a fix for anything. There is no need for a space there There is clearly whitespace in the template already.

{{ reset }}
{{ text_ip }}
{{ ip }}

I suspect @daretogo is using a version of PHP that is not compatible with the version of Twig they are using. https://forum.opencart.com/viewtopic.php?t=210652#p803802

@mhcwebdesign
Copy link
Collaborator

@ADDCreative: Some older versions of twig, as used in e.g. OpenCart 3.0.2.0, couldn't handle whitespaces correctly, as documented at https://twig.symfony.com/doc/3.x/templates.html#whitespace-control

However, this shouldn't be an issue with the 3.0.x.x_Maintenance branch because that one uses the latest version 3.6.1 of Symfony Twig. Personally I use the alternative OpenTwig engine (www.opentwig.org) on my client's websites.

@ADDCreative
Copy link
Contributor

@mhcwebdesign That was the exact point I was making. No need for this change in the 3.0.x.x_Maintenance branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants