Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content_bottom.php #2367

Closed
wants to merge 1 commit into from
Closed

Update content_bottom.php #2367

wants to merge 1 commit into from

Conversation

CoverUp
Copy link
Contributor

@CoverUp CoverUp commented Nov 27, 2014

Prevent double call and fix notices about undefined index, also fix order according priority.

Prevent double call and fix notices about undefined index, also fix order according priority.
@danielkerr
Copy link
Member

not worth the effort!

@danielkerr danielkerr closed this Dec 2, 2014
@CoverUp
Copy link
Contributor Author

CoverUp commented Dec 2, 2014

I think this is a good improvement...
just consider this example
you got a latest module, on oc_layout_module, code field: latest.31
current code will call module/latest without parameter, because
if (isset($part[0]) && $this->config->get($part[0] . '_status')) is true and is executed first
but calling latest without module will show the undefined $setting['limit'] warning, plus you are already running module/latest with all the others calls on it.
After this failed call, the if (isset($part[1])) part will execute, this time with success because you got the parameter.

So for each module on the layout the double call will be present, perhaps is negligible but they will sum , for the other hand the fix is also easy, so why don't fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants